Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDIOMS Update & BULKI v0.1 #203

Merged
merged 883 commits into from
Sep 10, 2024
Merged

IDIOMS Update & BULKI v0.1 #203

merged 883 commits into from
Sep 10, 2024

Conversation

zhangwei217245
Copy link
Collaborator

@zhangwei217245 zhangwei217245 commented Jun 24, 2024 •
edited
Loading

Related Issues / Pull Requests

Direct
#151 #169 #206

Indirect
#109 #132

Description

Major changes:

  • IDIOMS -> affix-based query benchmark
  • IDIOMS -> index persistence mechanism
  • IDIOMS -> numeric value query support (exact query and range query)
  • IDIOMS -> numeric value query benchmark
  • IDIOMS -> simulation test
  • BULKI V0.1 -> a data serialization and deserialization mechanism
  • Metadata JSON validator
  • Metadata JSON Loader for PDC

Minor changes

  • Updated Dockerfile for faster docker image build
  • Updated pdc_generic.h for full data type support capability and better ordering of PDC data type enums

In-progress changes

  • Some code for multi-condition query.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • [ x ] This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • [ x ] I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] New and existing unit tests pass locally with my changes

zhangwei217245 and others added 30 commits October 13, 2023 23:40
@zhangwei217245
Merge branch 'develop' of github.com:zhangwei217245/pdc into feature/…
48a370f 
…dart
@zhangwei217245
fix cmake mercury_util not found issue
ec6c6bc
@zhangwei217245
update for Julia support
f99a537
@zhangwei217245
fix hdf5.h not found for src/tools
0751a12
@zhangwei217245
update container config
c446108
@zhangwei217245
update container config
9911445
@zhangwei217245
update container config
8296539
@zhangwei217245
update container config
d1303da
@zhangwei217245
update container config
88a75e6
@zhangwei217245
update container config
923ec93
@zhangwei217245
update container config
9c3fbc4
@zhangwei217245
update container config
2f2c073
@zhangwei217245
update container config
49ef572
@zhangwei217245
update container config
199c1bb
@zhangwei217245
add libhdf5-dev for Github Actions
7fc75f0
@zhangwei217245
Merge branch 'develop' of github.com:zhangwei217245/pdc into feature/…
05511d7 
…dart
@zhangwei217245
update CMake for HDF5 in tools
11c8cec
@zhangwei217245
update logic for finding HDF5
71a23d5
@zhangwei217245
update
5e01ca9
@zhangwei217245
remove use system hdf5
d023c61
@zhangwei217245
delete useless find library
06cff1c
@zhangwei217245
update findHDF5
025f977
@zhangwei217245
update findHDF5
fd0e853
@zhangwei217245
update
a44f8a0
@zhangwei217245
update
3bb2529
@zhangwei217245
update
9fe8772
@zhangwei217245
update
71cf8d8
@zhangwei217245
Feature/dart (#11)
ca8e59d 
Update to avoid fixing compilation issue on src/tools (due to : HDF5 cannot be found)
@houjun
Use cc on Perlmutter (hpc-io#161)
1b6d60d 
Dr. Tang fixed a compilation issue in NERSC CI where HDF5 cannot be detected even if the cray-parallel-hdf5 module is loaded on Perlmultter.
@zhangwei217245
Merge branch 'hpc-io:develop' into develop
67791ef
houjun
houjun requested changes Sep 5, 2024
View reviewed changes
src/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@houjun

This comment was marked as off-topic.

Sign in to view
jeanbez

This comment was marked as resolved.

Sign in to view

@zhangwei217245
Copy link
Collaborator Author

@zhangwei217245, some parallel tests on Permlutter CI are failing, see the logs

  Start 139: idioms_ci_mpi
     24/24 Test #139: idioms_ci_mpi ....................***Failed    7.79 sec
     96% tests passed, 1 tests failed out of 24

There should not be parallel test case for now. I just removed it from CMake.

@zhangwei217245
Copy link
Collaborator Author

Please remove the src/api/test_bulki.bin file unless there is a need for it to be there.

Removed. Thank you for reminding.

@zhangwei217245 zhangwei217245 changed the title Draft: IDIOMS Update & BULKI v0.1 IDIOMS Update & BULKI v0.1 Sep 6, 2024
@jeanbez jeanbez merged commit 2e5de75 into hpc-io:develop Sep 10, 2024
7 checks passed
@hpc-io hpc-io deleted a comment from houjun Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbyna sbyna sbyna approved these changes

@jeanbez jeanbez jeanbez approved these changes

@houjun houjun houjun approved these changes

Assignees

@zhangwei217245 zhangwei217245

Labels
type: enhancement New feature or request type: new feature Request for new feature
Projects
None yet
Milestone
v.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangwei217245 @houjun @jeanbez @sbyna @hyunjuooh